For me, they have to work in cold conditions (below freezing temps). Many poles are difficult to adjust (the locking mechanism) when it gets cold, or the pole sections don’t slide easily.
They have to be adjustable while wearing mittens.
No screw-lock mechanisms. Cams only, eg BD Flicklocks.
As durable as you can make it for less than 16 oz/pr. Carbon is fine, but make it thick-walled.
Cork grips are better than foam. I like the weight concentrated at the handle, which makes for easier swinging.
No anti-shock. Gimmick. Adds weight and design complexity and cost and a failure point.
No bent handles. Gimmick for most users.
No Pacer Pole short length/really bent handles. Interesting for trail hiking but not versatile enough for mountain/snow/off-trail use.
My favorite poles right now are the Black Diamond Alpine Carbon Cork for trekking and mountaineering.
I like as light and as compact as possible with no adjustment for mountain running and fastpacking (balance only, so weight is important, because they spend a fair bit of time on my pack, or when I’m carrying I’m moving fast so would like minimal swing weight) – for me that’s the Black Diamond Distance Carbon Z – minimum weight, foam grips, no adjustability, maximum compactibility, less durability OK.
Our most recent trekking pole gear guide is here.